• merthyr1831@lemmy.world
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    3 months ago

    Heres my based af workflow:

    git checkout -b feature-branch

    rebase on top of dev whilst working locally

    git rebase origin/dev-branch && git push -f


    if i need to fix conflicts with dev-branch during a PR

    git merge origin/dev

  • tengkuizdihar@programming.dev
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    Please for the love of god don’t use merge, especially in a crowded repository. Don’t be me and suffer the consequences. I mistakenly mention every person with a commit between the time I created the branch until current master.

      • tengkuizdihar@programming.dev
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        really? how come? I thought they are mentioned because of the diffs if compared to master, which merge basically just… merge on top of my branch (?)

        • Atemu@lemmy.ml
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          They were mentioned because a file they are the code owner of was modified in the PR.

          The modifications came from another branch which you accidentally(?) merged into yours. The problem is that those commits weren’t in master yet, so GH considers them to be part of the changeset of your branch. If they were in master already, GH would only consider the merge commit itself part of the change set and it does not contain any changes itself (unless you resolved a conflict).

          If you had rebased atop of the other branch, you would have still had the commits of the other branch in your changeset; it’d be as if you tried to merge the other branch into master + your changes.

          • Bourff@lemmy.world
            link
            fedilink
            arrow-up
            0
            ·
            edit-2
            3 months ago

            Just for the record, I think you’re conflating git and GitHub. They are not the same thing, even if GH would like you to think so.

    • jaemo@sh.itjust.works
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      Could have been worse. I mean, like, imagine of you were using like CVS and you put a watch on the root! Haha and then like every trivial commit in the repo caused everyone to in the entire org to get an email and it crashed the email servers.

      Like who’d even DO that?! Though, I bet if you met that guy he’d be ok. Like not a jerk, and pretty sorry for all those emails. A cool guy.

    • droans@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      You sent over twenty-two thousand notifications lmao.

      And then the bot added about as many tags to the PR.

    • T156@lemmy.world
      link
      fedilink
      English
      arrow-up
      0
      ·
      3 months ago

      Wayland really doesn’t like RDP/remote access, so X is the only way to go if you want that to work properly.

      • AArun@programming.dev
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        I actually never had an issue on my wayland system. I used remmina for rdp but never had an issue.

    • 13@kbin.run
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      I use X because Cinnamon on Wayland has no option to change the keyboard layout

      • merthyr1831@lemmy.world
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        I tried their experimental Wayland session and it’s still super buggy on high refresh rate/high DPI screens (loads of graphical errors and artifacts) so still a ways to go imo

    • TheHarpyEagle@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      I tried it for a moment, made games stutter like hell, switched back. I know I need to go in and figure it out at some point, but it’s hard to muster the energy when X, for the most part, works fine.

      From what I’ve seen, it probably has to do with my Nvidia GPU.

      • 30p87@feddit.de
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        I’m currently at the point where I blame everything that works on my Laptop but not on my PC on Nvidia, because that’s literally the biggest difference between those two. Like currently my getty isn’t displaying properly, which is surely NVidias fault.

          • FiniteBanjo@lemmy.today
            link
            fedilink
            arrow-up
            0
            ·
            edit-2
            3 months ago

            Platforms of the same nature like Mastodon.social ? Because no.

            Actually, internal reports seem to indicate Twitter under Musk complies with much more takedown requests than it did previously, numbers seem to range from 80% to 98%, including requests from countries like China, Ethiopia, Turkey, etc. When people mention censorship by big tech the top three names are Twitter, Facebook, and Google. The only time I know of that twitter fought censorship was when India wanted them to takedown news about farmers’ protests, and Twitter lost in court, probably owing largely to the fact that he cut staff by 80% and ran the company’s finance into the ground by endorsing hate speech.

            • Zuberi 👀@lemmy.dbzer0.com
              link
              fedilink
              arrow-up
              0
              ·
              3 months ago

              No, I did not include mastodon in the “other platforms” because 99% of the normies aren’t on decentralized platforms anyway.

              Very small pond we’re discussing, as sad as that is.

              All I did was answer why THEY think Twitter is worth using. I personally don’t use Twitter, nor do I disagree w/ your take on censorship.

  • Cyborganism@lemmy.ca
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    I prefer to rebase as well. But when you’re working with a team of amateurs who don’t know how to use a VCS properly and never update their branc with the parent branch, you end up with lots of conflicts.

    I find that for managing conflicts, rebase is very difficult as you have to resolve conflicts for every commit. You can either use rerere to repeat the conflict resolution automatically, or you can squash everything. But when you’re dealing with a team of Git-illeterate developers (which is VERY often the case) you can either spend the time to educate them and still risk having problems because they don’t give a shit, or you can just do a regular merge and go on with your life.

    Those are my two cents, speaking from experience.

    • magic_lobster_party@kbin.run
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      How others are keeping their branches up to date is their problem. If you use Gitlab you can set up squash policy for merge requests. All the abomination they’ve caused in their branch will turn into one nice commit to the main branch.

      • expr@programming.dev
        cake
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        I don’t want squashed commits. It makes git tools worse (git bisect, git cherry-pick, etc.) and I work very hard to craft a meaningful set of commits for my work and I don’t want to throw all of that away.

        But yeah, I don’t actually give a shit what they are doing on their branches. I regularly rebase onto master anyway.

      • trxxruraxvr@lemmy.world
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        In a small team at a small company it becomes my problem pretty quickly, since I’m the only one that actually has some clue about what git does.

        • zalgotext@sh.itjust.works
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          Heaven forbid my teammates read any documentation or make any attempt to understand the tooling necessary to do their job.

          That being said, I taught my dumbass git-illiterate team members a rebase workflow, with the help of the git UI in Pycharm. Haven’t had any issues with merge conflicts yet, but that might just be because they’re too scared to ask me for help any more

        • Cyborganism@lemmy.ca
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          This. When they get any sort of conflicts in their pull request, it becomes MY problem because they don’t know what to do.

    • TechNom (nobody)@programming.dev
      link
      fedilink
      English
      arrow-up
      0
      ·
      3 months ago

      I agree that merge is the easier strategy with amateurs. By amateurs I mean those who cannot be bothered to learn about rebase. But what you really lose there is a nice commit history. It’s good to have, even if your primary strategy is merging. And people tend to create horrendous commit histories when they don’t know how to edit them.

      • xigoi@lemmy.sdf.org
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        Why would you want to edit your commit history? When I need to look at it for some reason, I want to see what actually happened, not a fictional story.

        • TechNom (nobody)@programming.dev
          link
          fedilink
          English
          arrow-up
          0
          ·
          3 months ago

          You can have both. I’ll get to that later. But first, let me explain why edited history is useful.

          Unedited histories are very chaotic and often contains errors, commits with partial features, abandoned code, reverted code, out-of-sequence code, etc. These are useful in preserving the actual progress of your own thought. But such histories are a nightmare to review. Commits should be complete (a single commit contains a full feature) and in proper order. If you’re a reviewer, you also wouldn’t want to waste time reviewing someone else’s mistakes, experiments, reverted code, etc. Self-complete commits also have another advantage - users can choose to omit an entire feature by omitting a commit.

          Now the part about having both - the unedited and carefully crafted history. Rebasing doesn’t erase the original branch. You can preserve it by creating a new branch. Or, you can recover it from reflog. I use it to preserve the original development history. Then I submit the edited/crafted history/branch upstream.

        • Atemu@lemmy.ml
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          Because when debugging, you typically don’t care about the details of wip, some more stuff, Merge remote-tracking branch 'origin/master', almost working, Merge remote-tracking branch 'origin/master', fix some tests etc. and would rather follow logical steps being taken in order with descriptive messages such as component: refactor xyz in preparation for feature, component: add do_foo(), component: implement feature using do_foo() etc.

      • AggressivelyPassive@feddit.de
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        Honestly, I’m pretty sure 99.9% of git users never really bother with the git history in any way that would be hindered by merging.

        Git has a ton of powerful features, but for most projects they don’t matter at all. You want a distributed consensus, that’s it. Bothering yourself with all those advanced features and trying to learn some esoteric commands is frankly just overhead. Yes, you can solve great problems with them, but these problems almost never occur, and if they do, using the stupid tools is faster overall.

        • TechNom (nobody)@programming.dev
          link
          fedilink
          English
          arrow-up
          0
          ·
          3 months ago

          Only users who don’t know rebasing and the advantages of a crafted history make statements like this. There are several projects that depend on clean commit history. You need it for conventional commit tools (like commitzen), pre-commit hook tools, git blame, git bisect, etc.

          • AggressivelyPassive@feddit.de
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            Uuuh, am I no true Scotsman?

            Counter argument: why do you keep fucking up so bad you need these tools? Only users who are bad at programming need these. Makes about as much sense as your accusation.

            You keep iterating the same arguments as the rest here, and I still adhere to my statement above: hardly anybody needs those tools. I literally never used pre-commit hooks or bisect in any semi-professional context. And I don’t know a single project that uses them. And before you counter with another “well u stoopid then” comment: the projects I’ve been working on were with pretty reputable companies and handled literally billions of Euros every year. I can honestly say, that pretty much everyone living in Germany had his/her data pushed through code that I wrote.

            • TechNom (nobody)@programming.dev
              link
              fedilink
              English
              arrow-up
              0
              ·
              3 months ago

              Uuuh, am I no true Scotsman?

              That’s a terrible and disingenuous take. I’m saying that you won’t understand why it’s useful till you’ve used it. Spinning that as no true Scotsman fallacy is just indicative of that ignorance.

              You keep iterating the same arguments as the rest here, and I still adhere to my statement above: hardly anybody needs those tools.

              And you keep repeating that falsehood. Isn’t that the real no true Scotsman fallacy? How do you even pretend to know that nobody needs it? You can’t talk for everyone else. Those who use it find it useful in several other ways that I and others have explained. You can’t just judge it away from your position of ignorance.

        • Chamomile 🐑@furry.engineer
          link
          fedilink
          arrow-up
          0
          ·
          edit-2
          3 months ago

          @agressivelyPassive @technom That’s a self-fulfilling prophecy, IMO. Well-structured commit histories with clear descriptions can be a godsend for spelunking through old code and trying to work out why a change was made. That is the actual point, after all - the Linux kernel project, which is what git was originally built to manage, is fastidious about this. Most projects don’t need that level of hygiene, but they can still benefit from taking lessons from it.

          To that end, sure, git can be arcane at the best of times and a lot of the tools aren’t strictly necessary, but they’re very useful for managing that history.

          • AggressivelyPassive@feddit.de
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            I’d still argue, that the overhead is not worth it most of the time.

            Linux is one of the largest single pieces of software in existence, of course it has different needs than the standard business crap the vast majority of us develop.

            To keep your analogy: not every room is an operating room, you might have some theoretical advantages from keeping your kitchen as clean as an OR, but it’s probably not worth the hassle.

            • zalgotext@sh.itjust.works
              link
              fedilink
              arrow-up
              0
              ·
              3 months ago

              To keep your analogy, most people’s git histories, when using a merge-based workflow, is the equivalent of never cleaning the kitchen, ever.

              • AggressivelyPassive@feddit.de
                link
                fedilink
                arrow-up
                0
                ·
                3 months ago

                No, it’s not. And you know that.

                Seriously, ask yourself, how often did the need arise to look into old commits and if it did, wasn’t the underlying issue caused by the processes around it? I’ve been in the industry for a few years now and I can literally count on one hand how often I had to actually look at commit history for more than maybe 10 commits back. And I spend maybe 10min per year on that on average, if at all.

                I honestly don’t see a use case that would justify the overhead. It’s always just “but what if X, then you’d save hours!” But X never happens or X is caused by a fucked up process somewhere else and git is just the hammer to nail down every problem.

                • zalgotext@sh.itjust.works
                  link
                  fedilink
                  arrow-up
                  0
                  ·
                  3 months ago

                  Seriously, ask yourself, how often did the need arise to look into old commits

                  Literally every single day. I have a git alias that prints out the commit graph for my repositories, and by looking at that I can instantly see what tasks my coworkers are working on, what their progress is, and what their work is based on. It’s way more useful than any stand-up meeting I’ve ever attended.

                  I’ve been in the industry for a few years now and I can literally count on one hand how often I had to actually look at commit history for more than maybe 10 commits back.

                  I’ve been in the industry for nearly 15 years, but I can say that the last 3 years have been my most productive, and I attribute a lot of that to the fact that I’m on a team that cares about git history, knows how to use it, and keeps it readable. Like other people have been saying, this is a self fulfilling prophecy - most people don’t care to keep their git history readable, so they’ve only ever seen unreadable git histories, and so they think git history is useless.

                  I honestly don’t see a use case that would justify the overhead.

                  What overhead? The learning curve on rebasing isn’t that much steeper than that of merging or just using git itself. Take an hour to read the git docs, watch a tutorial or two, and you’re good to go. Understand that people actually read your commit messages and take 15 extra seconds to make them actually useful. Take an extra minute before opening an MR to rebase your personal branches interactively and squash down the “fixed a typo” and “ran isort” commits into something that’s actually useful. In the long run this saves time by making your code more easily reviewable, and giving reviewers useful context around your changes.

                  It’s always just “but what if X, then you’d save hours!” But X never happens or X is caused by a fucked up process somewhere else and git is just the hammer to nail down every problem.

                  No, having a clean, readable git history literally saves my team hours. I haven’t had to manually write or edit a changelog in three years because we generate it automatically from our commit messages. I haven’t had to think about a version number in three years because they’re automatically calculated from our commit messages. Those are the types of things teams sink weeks into, time absolutely wasted spent arguing over whether this thing or that is a patch bump or a minor bump, and no one can say for sure without looking at diffs or spinning up multiple versions of the code and poking it manually, because the git log is a tangled mess of spaghetti with meatballs made of messages like “finally fixed the thing” and “please just work dammit”. My team can tell you those things instantly just by looking at the git log. Because we care about history, and we keep it clean and useable.

          • zalgotext@sh.itjust.works
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            Yup, once you can use git with good hygiene, it opens up the door to add in other tools like commitizen and semantic-release, which completely automates things like version number bumps and changelog generation.

  • katy ✨@lemmy.blahaj.zone
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    i like to create ten different checkouts of main, rebase them all slightly differently and then no fast forward merge them all back into each other

  • JoYo@lemmy.ml
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    Anyone mind explaining to me how git rebase is worth the effort?

    git merge has it’s own issues but I just don’t see any benefit to rebase over it.

    • Aux@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      Well, rebase allows you to resolve the same conflict ten times in a row instead of doing it once. How cool is that?

    • bitcrafter@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      The way I structure my commits, it is usually (but not always) easier and more reliable for me to replay my commits one at a time on top of the main branch and see how each relatively small change needs to be adapted in isolation–running the full test suite at each step to verify that my changes were correct–than to be presented with a slew of changes all at once that result from marrying all of my changes with all of the changes made to the main branch at once. So I generally start by attempting a rebase and fall back to a merge if that ends up creating more problems than it solves.

    • Jesus_666@feddit.de
      link
      fedilink
      arrow-up
      0
      ·
      edit-2
      3 months ago

      I use interactive rebases to clean up the history of messy branches so they can be reviewed commit by commit, with each commit representing one logical unit or type of change.

      Mind you, getting those wrong is a quick way to making commits disappear into nothingness. Still useful if you’re careful. (Or you can just create a second temporary branch you can fall back onto of you need up your first once.)

      • bamboo@lemmy.blahaj.zone
        link
        fedilink
        English
        arrow-up
        0
        ·
        3 months ago

        This 100%. I hate getting added to a PR for review with testing commits in the history, and I’m expected to clean those up before merging into main.

        • Zangoose@lemmy.one
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          I feel like squash and merge on GitHub/GitLab is nicer for that anyway though, it makes the main branch so much cleaner automatically

  • Croquette@sh.itjust.works
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    I know this is a meme post, but can someone succinctly explain rebase vs merge?

    I am an amateur trying to learn my tool.

    • jaemo@sh.itjust.works
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      Merge keeps the original timeline. Your commits go in along with anything else that happened relative to the branch you based your work off (probably main). This generates a merge commit.

      Rebase will replay all the commits that happened while you were doing your work before your commits happen, and then put yours at the HEAD, so that they are the most recent commits. You have to mitigate any conflicts that impact the same files as these commits are replayed, if any conflicts arise. These are resolved the same way any merge conflict is. There is no frivolous merge commit in this scenario.

      TlDR; End result, everything that happened to the branch minus your work, happens. Then your stuff happens after. Much tidy and clean.

      • Croquette@sh.itjust.works
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        Thanks for the explanation. It makes sense. To my untrained eyes, it feels like both merge and rebase have their use. I will try to keep that in mind.

        • jaemo@sh.itjust.works
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          100% they do. Rebase is an everyday thing, merge is for PRs (for me anyway). Or merges are for regular branches if you roll that way. The only wrong answer is the one that causes you to lose commits and have to use reflog, cos…well, then you done messed up now son… (but even then hope lives on!)

        • JackbyDev@programming.dev
          link
          fedilink
          English
          arrow-up
          0
          ·
          3 months ago

          Yes. They do. A lot of people will use vacuous terms like “clean history” when arguing for one over the other. In my opinion, most repositories have larger problems than rebase versus merge. Like commit messages.

          Also, remember, even if your team/repository prefers merges over rebases for getting changes into the main branch, that doesn’t mean you shouldn’t be using rebase locally for various things.

          • Croquette@sh.itjust.works
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            How would rebasing my own branch work? Do I rebase the main into my branch, or make a copy of the main branch and then rebase? I have trouble grasping how that would work.

            • JackbyDev@programming.dev
              link
              fedilink
              English
              arrow-up
              0
              ·
              3 months ago

              You’re still rebasing your branch onto main (or whatever you originally branched it off of), but you aren’t then doing a fast forward merge of main to your branch.

              The terminology gets weird. When people say “merge versus rebase” they really mean it in the context of brining changes into main. You (or the remote repository) cannot do this without a merge. People usually mean “merge commit versus rebase with fast forward merge”

            • jaemo@sh.itjust.works
              link
              fedilink
              arrow-up
              0
              ·
              3 months ago

              Here’s an example

              Say I work on authentication under feature/auth Monday and get some done. Tuesday an urgent feature request for some logging work comes in and I complete it on feature/logging and merge clean to main. To make sure all my code from Monday will work, I will then switch to feature/auth and then git pull --rebase origin main. Now my auth commits start after the merge commit from the logging pr.

              • jaemo@sh.itjust.works
                link
                fedilink
                arrow-up
                0
                ·
                3 months ago

                https://gitmoji.dev/

                Quasi parallel reply to your other post, this would kind of echo the want for a capital letter at the start of the commit message. Icon indicates overall topic nature of commits.

                Lets say I am adding a database migration and my commit is the migration file and the schema. My commit message might be:

                     🗃️ Add notes to Users table
                

                So anyone looking at the eventual pr will see the icon and know that this bunch of work will affect db without all that tedious “reading the code” part of the review, or for team members who didn’t participate in reviews.

                I was initially hesitant to adopt it but I have very reasonable, younger team mates for whom emojis are part of the standard vocabulary. I gradually came to appreciate and value the ability to convey more context in my commits this way. I’m still guilty of the occasionally overusing:

                   ♻️ Fix the thing
                

                type messages when I’m lazy; doesn’t fix that bad habit, but I’m generally much happier reading mine or someone else’s PR commit summary with this extra bit of context added.

                • Deebster@programming.dev
                  link
                  fedilink
                  arrow-up
                  0
                  ·
                  3 months ago

                  I looked at it and there’s a lot of them!

                  I see things like adding dependencies but I would add the dependency along with the code that’s using it so I have that context. Is the Gitmoji way to break your commits up so that it matches a single category?

            • JackbyDev@programming.dev
              link
              fedilink
              English
              arrow-up
              0
              ·
              3 months ago

              I must have read that blog post in the past because that’s exactly the style I use. Much of it is standard though.

              One MAJOR pet peeve of mine (and I admit it is just an opinion either way) is when people use lower case letters for the first line of the commit message. They typically argue that it is a sentence fragment so shouldn’t be capitalized. My counter is that the start of sentences, even fragmented ones, should be capitalized. Also, and more relevant, is that I view the first line of the commit more like the title of something than a sentence. So I use the Wikipedia style of capitalizing.

        • bitcrafter@programming.dev
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          Yes. My rule of thumb is that generally rebasing is the better approach, in part because if your commit history is relatively clean then it is easier to merge in changes one commit at a time than all at once. However, sometimes so much has changed that replaying your commits puts you in the position of having to solve so many problems that it is more trouble than it is worth, in which case you should feel no qualms about aborting the rebase (git rebase --abort) and using a merge instead.

    • letsgo@lemm.ee
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      Merge gives an accurate view of the history but tends to be “cluttered” with multiple lines and merge commits. Rebase cleans that up and gives you a simple A->B->C view.

      Personally I prefer merge because when I’m tracking down a bug and narrow it down to a specific commit, I get to see what change was made in what context. With rebase commits that change is in there, but it’s out of context and cluttered up with zillions of other changes from the inherent merges and squashes that are included in that commit, making it harder to see what was changed and why. The same cluttered history is still in there but it’s included in the commits instead of existing separately outside the commits.

      I honestly can’t see the point of a rebased A->B->C history because (a) it’s inaccurate and (b) it makes debugging harder. Maybe I’m missing some major benefit? I’m willing to learn.

      • reflectedodds@lemmy.world
        link
        fedilink
        arrow-up
        0
        ·
        edit-2
        3 months ago

        I feel the opposite, but for similar logic? Merge is the one that is cluttered up with other merges.

        With rebase you get A->B->C for the main branch, and D->E->F for the patch branch, and when submitting to main you get a nice A->B->C->D->E->F and you can find your faulty commit in the D->E->F section.

        For merge you end up with this nonsense of mixed commits and merge commits like A->D->B->B’->E->F->C->C’ where the ones with the apostrophe are merge commits. And worse, in a git lot there is no clear “D E F” so you don’t actually know if A, D or B came from the feature branch, you just know a branch was merged at commit B’. You’d have to try to demangle it by looking at authors and dates.

        The final code ought to look the same, but now if you’re debugging you can’t separate the feature patch from the main path code to see which part was at fault. I always rebase because it’s equivalent to checking out the latest changes and re-branching so I’m never behind and the patch is always a unique set of commits.

        • Atemu@lemmy.ml
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          For merge you end up with this nonsense of mixed commits and merge commits like A->D->B->B’->E->F->C->C’ where the ones with the apostrophe are merge commits.

          Your notation does not make sense. You’re representing a multi-dimensional thing in one dimension. Of course it’s a mess if you do that.

          Your example is also missing a crucial fact required when reasoning about merges: The merge base.
          Typically a branch is “branched off” from some commit M. D’s and A’s parent would be M (though there could be any amount of commits between A and M). Since A is “on the main branch”, you can conclude that D is part of a “patch branch”. It’s quite clear if you don’t omit this fact.

          I also don’t understand why your example would have multiple merges.

          Here’s my example of a main branch with a patch branch; in 2D because merges can’t properly be represented in one dimension:

          M - A - B - C - C'
            \           /
              D - E - F
          

          The final code ought to look the same, but now if you’re debugging you can’t separate the feature patch from the main path code to see which part was at fault.

          If you use a feature branch workflow and your main branch is merged into, you typically want to use first-parent bisects. They’re much faster too.

          • reflectedodds@lemmy.world
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            You’re right, I’m not representing the merge correctly. I was thinking of having multiple merges because for a long running patch branch you might merge main into the patch branch several times before merging the patch branch into main.

            I’m so used to rebasing I forgot there’s tools that correctly show all the branching and merges and things.

            Idk, I just like rebase’s behavior over merge.

            • Atemu@lemmy.ml
              link
              fedilink
              arrow-up
              0
              ·
              3 months ago

              The thing is, you can get your cake and eat it too. Rebase your feature branches while in development and then merge them to the main branch when they’re done.

      • ActionHank@sopuli.xyz
        link
        fedilink
        arrow-up
        0
        ·
        edit-2
        3 months ago

        I would advocate for using each tool, where it makes sense, to achieve a more intelligible graph. This is what I’ve been moving towards on my personal projects (am solo). I imagine with any moderately complex group project it becomes very difficult to keep things neat.

        In order of expected usage frequency:

        1. Rebase: everything that’s not 2 or 3. keep main and feature lines clean.
        2. Merge: ideally, merge should only be used to bring feature branches into main at stable sequence points.
        3. Squash: only use squash to remove history that truly is useless. (creating a bug on a feature branch and then solving it two commits later prior to merge).

        History should be viewable from log --all --decorate --oneline --graph; not buried in squash commits.

  • MyNamesNotRobert@lemmynsfw.com
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    3 months ago

    I know how to use git pull, git push, git commit, git status and git add *. I don’t even know how git commit and git push works I just know you run them in that order. Whenever I break everything I give up and go outside.

  • jjjalljs@ttrpg.network
    cake
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    I used to only merge. Now I rebase. The repo is set up to require squash and rebase when going to main.

    All the garbage “spelled thing wrong” and “ran formatter” commits go away. Main is clean and linear.

      • jjjalljs@ttrpg.network
        cake
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        …and? You squash so all your gross “isort” “forgot to commit this file” “WIP but I’m getting lunch” commits can be cleaned up into a single “Add endpoint to allow users to set their blah blah” comment with a nice extended description.

        You then rebase so you have a nice linear history with no weird merge commits hanging around.

        • cobra89@beehaw.org
          link
          fedilink
          arrow-up
          0
          ·
          3 months ago

          Okay honest question, when you merge a PR in GitHub and choose the squash commits box is that “rebasing”? Or is that just squashing? Because it seems that achieves the same thing you’re talking about.

          • jjjalljs@ttrpg.network
            cake
            link
            fedilink
            arrow-up
            0
            ·
            3 months ago

            There’s two options in the green button on a pr. One is squash and merge, the other is squash and rebase.

            Squashing makes one commit out of many. You should IMO always do this when putting your work on a shared branch

            Rebase takes your commit(s) and sticks them on the end.

            Merge does something else I don’t understand as well, and makes a merge commit.

            Also there was an earthquake in NYC when I was writing this. We may have angered the gods.

            • Atemu@lemmy.ml
              link
              fedilink
              arrow-up
              0
              ·
              3 months ago

              You should IMO always do this when putting your work on a shared branch

              No. You should never squash as a rule unless your entire team can’t be bothered to use git correctly and in that case it’s a workaround for that problem, not a generally good policy.

              Automatic squashes make it impossible to split commit into logical units of work. It reduces every feature branch into a single commit which is quite stupid.
              If you ever needed to look at a list of feature branch changes with one feature branch per line for some reason, the correct tool to use is a first-parent log. In a proper git history, that will show you all the merge commits on the main branch; one per feature branch; as if you had squashed.

              Rebase “merges” are similarly stupid: You lose the entire notion of what happened together as a unit of work; what was part of the same feature branch and what wasn’t. Merge commits denote the end of a feature branch and together with the merge base you can always determine what was committed as part of which feature branch.

              • jjjalljs@ttrpg.network
                cake
                link
                fedilink
                arrow-up
                0
                ·
                3 months ago

                I don’t want to see a dozen commits of “ran isort” “forgot to commit this file lol” quality.

                Do you?

                Having the finished feature bundled into one commit is nice. I wouldn’t call it stupid at all.

  • passepartout@feddit.de
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    I like the idea of it and there were times i used it correctly, but most of the time i do it wrong i guess.

  • Margot Robbie@lemm.ee
    link
    fedilink
    arrow-up
    0
    ·
    3 months ago

    I think this is a fake quote that somebody made up for an Internet comedy bit, since it seems unlikely for Hollywood actress Sydney Sweeney to have such uncharacteristically strong opinion on software version control, of all things.

    Because she of all people would know that there isn’t anything wrong with using git merge, and it ultimately comes down to personal preference to what you are used to.

    • hactar42@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      I think this is a fake quote that somebody made up for an Internet comedy bit

      You can tell by the pixels

    • Jax@sh.itjust.works
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      But esteemed Academy Award nominated character actress and film director, Margot Robbie, if it’s unlikely that Hollywood actress Sydney Sweeney said this… wouldn’t it be just as unlikely that Margot Robbie would be here? Adding her own comment?

      … are you projecting? Is there something you want to tell us esteemed Academy Award nominated character actress and film director Margot Robbie?

      • ManniSturgis@lemmy.zip
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        Wait a second, there wasn’t even any social media sites back when Benjamin Franklin lived. Did he write that in his newsletter or something?

    • Artyom@lemm.ee
      link
      fedilink
      arrow-up
      0
      ·
      3 months ago

      Margot Robbie, I was about to agree with you and thought that was a very reasonable take, until you tried to argue that git merge is better than git rebase, then I simply had to disregard the whole thing.