• m_f@midwest.social
    link
    fedilink
    arrow-up
    2
    ·
    1 year ago

    That’s 👏 what 👏 CI 👏 is 👏 for

    Warn in dev, enforce stuff like this in CI and block PRs that don’t pass. Go is just being silly here, which is not surprising given that Rob Pike said

    Syntax highlighting is juvenile. When I was a child, I was taught arithmetic using colored rods. I grew up and today I use monochromatic numerals.

    The Go developers need to get over themselves.

    • merc@sh.itjust.works
      link
      fedilink
      arrow-up
      1
      ·
      1 year ago

      Yeah, insisting on things like a variable being used will result in people using work arounds. It won’t result in people not doing it.

      Then, because people trust the language to police this rule, the work-arounds and debug code will get committed.

      func main() {  
          test := true  
      }  
      

      Oops, golang doesn’t like that.

      func main() {  
          test := true  
          _ = test  
      }
      

      Perfectly cromulent code.

      If they really wanted to avoid people having unused variables, they should have used a naming convention. Any variable not prefixed by “_” or “_debug_” or whatever has to be used, for example. Then block any code being checked in that still contains those markers.

    • FlumPHP@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      1 year ago

      What’s a situation where you need an unused variable? I’m onboard with go and goland being a bit aggressive with this type of thing, but I can’t think of the case where I need to be able to commit an unused variable.

      • hare_ware@pawb.social
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        I will need it two minutes tops. If I don’t use it by then, I’ll delete it, especially if it gives a warning like Rust does. But this? It just gets in the way.

      • jormaig@programming.dev
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        Have you looked at the post? Use case: you are testing something or playing around and you want to try something. That’s supper common

      • m_f@midwest.social
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        You probably wouldn’t be committing this, unless you’re backing up a heavily WIP branch. The issue is that if you’re developing locally and need to make a temporary change, you might comment something out, which then requires commenting another now-unused variable, which then requires commenting out yet another variable, and so on. Go isn’t helping you here, it’s wasting your time for no good reason. Just emit a warning and allow CI to be configured to reject warnings.